Re: [PATCH 0/13] parseopt fixes from -Wunused-parameters

2018-11-05 Thread Duy Nguyen
On Mon, Nov 5, 2018 at 7:49 PM Jeff King wrote: > > On Mon, Nov 05, 2018 at 05:51:07PM +0100, Duy Nguyen wrote: > > > On Mon, Nov 5, 2018 at 7:39 AM Jeff King wrote: > > > > > > Continuing my exploration of what -Wunused-parameters can show us, here > > > are some bug-fixes related to

Re: [PATCH 0/13] parseopt fixes from -Wunused-parameters

2018-11-05 Thread Jeff King
On Mon, Nov 05, 2018 at 05:51:07PM +0100, Duy Nguyen wrote: > On Mon, Nov 5, 2018 at 7:39 AM Jeff King wrote: > > > > Continuing my exploration of what -Wunused-parameters can show us, here > > are some bug-fixes related to parse-options callbacks. > > > > This is the last of the actual

Re: [PATCH 0/13] parseopt fixes from -Wunused-parameters

2018-11-05 Thread Duy Nguyen
On Mon, Nov 5, 2018 at 7:39 AM Jeff King wrote: > > Continuing my exploration of what -Wunused-parameters can show us, here > are some bug-fixes related to parse-options callbacks. > > This is the last of the actual bug-fixes I've found. After this, I have > about 60 patches worth of cleanups

[PATCH 0/13] parseopt fixes from -Wunused-parameters

2018-11-04 Thread Jeff King
Continuing my exploration of what -Wunused-parameters can show us, here are some bug-fixes related to parse-options callbacks. This is the last of the actual bug-fixes I've found. After this, I have about 60 patches worth of cleanups (i.e., dropping the unused parameters), and then I have a