Re: [PATCH 0/2] -Wuninitialized

2018-03-20 Thread Ramsay Jones
On 20/03/18 14:46, Johannes Schindelin wrote: > Hi Ramsay, > > On Mon, 19 Mar 2018, Ramsay Jones wrote: > >> This series removes all 'self-initialised' variables (ie. var = >> var;). This construct has been used to silence gcc >> '-W[maybe-]uninitialized' warnings in the past [1].

Re: [PATCH 0/2] -Wuninitialized

2018-03-20 Thread Ramsay Jones
On 20/03/18 04:32, Jeff King wrote: > On Mon, Mar 19, 2018 at 05:53:09PM +, Ramsay Jones wrote: >> If we now add a patch to remove all self-initialization, which would be the >> first patch plus the obvious change to 'saved_namelen' in read-cache.c, then >> note the warnings issued by

Re: [PATCH 0/2] -Wuninitialized

2018-03-20 Thread Johannes Schindelin
Hi Ramsay, On Mon, 19 Mar 2018, Ramsay Jones wrote: > This series removes all 'self-initialised' variables (ie. var = > var;). This construct has been used to silence gcc > '-W[maybe-]uninitialized' warnings in the past [1]. Unfortunately, this > construct causes warnings to be issued by MSVC

Re: [PATCH 0/2] -Wuninitialized

2018-03-19 Thread Jeff King
On Mon, Mar 19, 2018 at 05:53:09PM +, Ramsay Jones wrote: > This series removes all 'self-initialised' variables (ie. var = var;). > This construct has been used to silence gcc '-W[maybe-]uninitialized' warnings > in the past [1]. Unfortunately, this construct causes warnings to be issued by

[PATCH 0/2] -Wuninitialized

2018-03-19 Thread Ramsay Jones
This series removes all 'self-initialised' variables (ie. var = var;). This construct has been used to silence gcc '-W[maybe-]uninitialized' warnings in the past [1]. Unfortunately, this construct causes warnings to be issued by MSVC [2], along with clang static analysis complaining about an