Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-09 Thread Jonathan Tan
> > An argument could be made that we should not merge patch 2 just yet due > > to the fact that some server implementations (such as Git and JGit) > > still exhibit the old behavior, and the resulting clones (albeit failing > > fsck) are still usable, because when attempting to load the blob, Git

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-09 Thread Junio C Hamano
Jonathan Tan writes: > When cloning a repository with a tagged blob (like the Git repository) > with --filter=blob:none, the following message appears: > > error: missing object referenced by 'refs/tags/junio-gpg-pub' > > and the resulting repository also fails fsck. > > Patch 1 fixes

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-09 Thread Jonathan Tan
> I think that refs in files-backend is a bit hard to update to > annotate with extra information like "is this merely promising or a > tip of the connectivity graph?" and agree that we should not make > refs promisors. OK, we agree on this :-) > Such an otherwise unreferenced blob could be made

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-09 Thread Junio C Hamano
Jonathan Nieder writes: When cloning a repository with a tagged blob (like the Git repository) with --filter=blob:none, the following message appears: error: missing object referenced by 'refs/tags/junio-gpg-pub' and the resulting repository also fails fsck.

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-06 Thread Junio C Hamano
Jonathan Nieder writes: > The upsides are that > ... > - down the line, it should make operations like "fetch just this one > tree" a little simpler, since you can use > >filter blob:none >filter tree:none >want ;-) I think this example, especially without the first line, would

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-06 Thread Jonathan Nieder
Hi, Junio C Hamano wrote: >> Jonathan Tan writes: >>> When cloning a repository with a tagged blob (like the Git repository) >>> with --filter=blob:none, the following message appears: >>> >>> error: missing object referenced by 'refs/tags/junio-gpg-pub' >>> >>> and the resulting

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-06 Thread Jonathan Tan
> Hmph, the approach taken by these two patches smells bad. > > When a blob is deliberately omitted with --fitler=blob:none, the > fsck that encounters an entry in a tree object that is about that > expected-to-be-and-actually-is-missing blob does *not* complain and > that is by design, right?

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-06 Thread Junio C Hamano
Jonathan Tan writes: >> When cloning a repository with a tagged blob (like the Git repository) >> with --filter=blob:none, the following message appears: >> >> error: missing object referenced by 'refs/tags/junio-gpg-pub' >> >> and the resulting repository also fails fsck. Hmph, the

Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-06 Thread Jonathan Tan
> When cloning a repository with a tagged blob (like the Git repository) > with --filter=blob:none, the following message appears: > > error: missing object referenced by 'refs/tags/junio-gpg-pub' > > and the resulting repository also fails fsck. > > Patch 1 fixes the protocol

[PATCH 0/2] Avoiding errors when partial cloning a tagged blob

2018-07-06 Thread Jonathan Tan
When cloning a repository with a tagged blob (like the Git repository) with --filter=blob:none, the following message appears: error: missing object referenced by 'refs/tags/junio-gpg-pub' and the resulting repository also fails fsck. Patch 1 fixes the protocol documentation and the