On Tue, May 09, 2017 at 09:58:28AM +0200, Ævar Arnfjörð Bjarmason wrote:
> > Out of curiosity, how do you generate the patch-ids? Is it with
> > something like diff-tree piped to patch-id?
>
> This:
>
> my $cmd = qq[git --git-dir="$repository_path" log --since="$since"
> --until="$until"
On Tue, May 9, 2017 at 5:16 AM, Jeff King wrote:
> On Mon, May 01, 2017 at 12:34:38PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> > I don't know if we would want to be extra paranoid about patch-ids.
>> > There is no helping:
>> >
>> > git rev-list HEAD | git diff-tree --stdin -p
Jeff King writes:
> I do feel a bit sad about breaking this case (or at the very least
> forcing you to set an option to retain cross-version compatibility). But
> my gut says that we don't want to lock ourselves into never changing the
> diff algorithm (and I'm sure we've done it
On Mon, May 01, 2017 at 12:34:38PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > I don't know if we would want to be extra paranoid about patch-ids.
> > There is no helping:
> >
> > git rev-list HEAD | git diff-tree --stdin -p | git patch-id --stable
> >
> > because diff-tree doesn't know that it's
On Sat, Apr 29, 2017 at 12:04 AM, Jeff King wrote:
> On Fri, Apr 28, 2017 at 10:34:15AM -0700, Stefan Beller wrote:
>
>> > So instead I chose to make the indentHeuristic option part of diff's basic
>> > configuration, and in each of the diff plumbing commands I moved the call
>> >
On Fri, Apr 28, 2017 at 3:04 PM, Jeff King wrote:
> On Fri, Apr 28, 2017 at 10:34:15AM -0700, Stefan Beller wrote:
>
>> > So instead I chose to make the indentHeuristic option part of diff's basic
>> > configuration, and in each of the diff plumbing commands I moved the call
>> >
On Fri, Apr 28, 2017 at 10:34:15AM -0700, Stefan Beller wrote:
> > So instead I chose to make the indentHeuristic option part of diff's basic
> > configuration, and in each of the diff plumbing commands I moved the call to
> > git_config() before the call to init_revisions().
> [...]
>
> The
On Thu, Apr 27, 2017 at 1:50 PM, Marc Branchaud wrote:
> So here's my attempt at fixing this.
>
> The thing I was missing is that init_revisions() calls diff_setup(), which
> sets the xdl options. It's therefore necessary to have the
> diff_indent_heuristic flag set before
On Thu, Apr 27, 2017 at 04:50:35PM -0400, Marc Branchaud wrote:
> So here's my attempt at fixing this.
>
> The thing I was missing is that init_revisions() calls diff_setup(), which
> sets the xdl options. It's therefore necessary to have the
> diff_indent_heuristic flag set before calling
So here's my attempt at fixing this.
The thing I was missing is that init_revisions() calls diff_setup(), which
sets the xdl options. It's therefore necessary to have the
diff_indent_heuristic flag set before calling init_revisions().
A naive way to get the indentHeuristic config option
10 matches
Mail list logo