Re: [PATCH 0/2] git-config and large integers

2013-08-20 Thread Jeff King
On Tue, Aug 20, 2013 at 04:41:30PM -0700, Junio C Hamano wrote: > If this applied on the writing side, I would understand it very > much, i.e. > > $ git config --int32 foo.size 2g > fatal: "2g" is too large to be read as "int32". It does, by the way. When you request a type on the

Re: [PATCH 0/2] git-config and large integers

2013-08-20 Thread Jeff King
On Tue, Aug 20, 2013 at 04:06:19PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I was playing with a hook for file size limits that wanted to store the > > limit in git-config. It turns out we don't do a very good job of big > > integers: > > > > $ git config foo.size 2g > > $ git

Re: [PATCH 0/2] git-config and large integers

2013-08-20 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> I was playing with a hook for file size limits that wanted to store the >> limit in git-config. It turns out we don't do a very good job of big >> integers: >> >> $ git config foo.size 2g >> $ git config --int foo.size >> -2147483648 >> >> Oo

Re: [PATCH 0/2] git-config and large integers

2013-08-20 Thread Junio C Hamano
Jeff King writes: > I was playing with a hook for file size limits that wanted to store the > limit in git-config. It turns out we don't do a very good job of big > integers: > > $ git config foo.size 2g > $ git config --int foo.size > -2147483648 > > Oops. After this series, we properly no

Re: [PATCH 0/2] git-config and large integers

2013-08-20 Thread Jeff King
On Wed, Aug 21, 2013 at 12:44:22AM +0200, Stefan Beller wrote: > On 08/21/2013 12:39 AM, Jeff King wrote: > > I was playing with a hook for file size limits that wanted to store the > > limit in git-config. It turns out we don't do a very good job of big > > integers: > > > > $ git config foo.s

Re: [PATCH 0/2] git-config and large integers

2013-08-20 Thread Stefan Beller
On 08/21/2013 12:39 AM, Jeff King wrote: > I was playing with a hook for file size limits that wanted to store the > limit in git-config. It turns out we don't do a very good job of big > integers: > > $ git config foo.size 2g > $ git config --int foo.size > -2147483648 > > Oops. After this

[PATCH 0/2] git-config and large integers

2013-08-20 Thread Jeff King
I was playing with a hook for file size limits that wanted to store the limit in git-config. It turns out we don't do a very good job of big integers: $ git config foo.size 2g $ git config --int foo.size -2147483648 Oops. After this series, we properly notice the error: $ git config --in