[PATCH 0/3] a small branch API clean-up

2017-10-12 Thread Junio C Hamano
This started as a little clean-up for a NEEDSWORK comment in branch.h, but it ended up adding a rather useful safety feature. Junio C Hamano (3): branch: streamline "attr_only" handling in validate_new_branchname() branch: split validate_new_branchname() into two branch: forbid refs/heads/HE

Re: [PATCH 0/3] a small branch API clean-up

2017-10-20 Thread Kaartic Sivaraam
On Fri, 2017-10-13 at 14:11 +0900, Junio C Hamano wrote: > This started as a little clean-up for a NEEDSWORK comment in > branch.h, but it ended up adding a rather useful safety feature. > Part of this series seems to duplicate the work done in part of my series that tries to give more useful err

Re: [PATCH 0/3] a small branch API clean-up

2017-10-21 Thread Junio C Hamano
Kaartic Sivaraam writes: > On Fri, 2017-10-13 at 14:11 +0900, Junio C Hamano wrote: >> This started as a little clean-up for a NEEDSWORK comment in >> branch.h, but it ended up adding a rather useful safety feature. >> > > Part of this series seems to duplicate the work done in part of my > seri

Re: [PATCH 0/3] a small branch API clean-up

2017-10-21 Thread Kaartic Sivaraam
On Sat, 2017-10-21 at 17:52 +0900, Junio C Hamano wrote: > > Sorry, but I am not sure what you are asking. > > I was looking at the code, noticed NEEDSWORK comment and worked on > cleaning things up---you seem to feel that I need a reason, or > perhaps even your permission, when I try improving