Re: [PATCH 0/3] fix local_tzoffset with far-in-future dates

2016-06-21 Thread Jeff King
On Mon, Jun 20, 2016 at 11:37:50PM -0700, Norbert Kiesel wrote: > There are more strange things happening with dates. One example is > that `git commit --date=@4102444799` produces a commit with the > correct author date "Thu Dec 31 15:59:59 2099 -0800" (for my local > timezone which is

Re: [PATCH 0/3] fix local_tzoffset with far-in-future dates

2016-06-21 Thread Norbert Kiesel
There are more strange things happening with dates. One example is that `git commit --date=@4102444799` produces a commit with the correct author date "Thu Dec 31 15:59:59 2099 -0800" (for my local timezone which is Americas/Los_Angeles), while `git commit --date=@4102444800` produces a commit

Re: [PATCH 0/3] fix local_tzoffset with far-in-future dates

2016-06-20 Thread Jeff King
On Mon, Jun 20, 2016 at 03:11:23PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I still don't know how that screwed-up timestamp got _into_ > > a commit, so perhaps there is another bug lurking. I couldn't convince > > git to parse anything beyond 2100, and committing

Re: [PATCH 0/3] fix local_tzoffset with far-in-future dates

2016-06-20 Thread Junio C Hamano
Jeff King writes: > I still don't know how that screwed-up timestamp got _into_ > a commit, so perhaps there is another bug lurking. I couldn't convince > git to parse anything beyond 2100, and committing with > GIT_AUTHOR_DATE='@5758122296 +' works just fine. Interesting.

[PATCH 0/3] fix local_tzoffset with far-in-future dates

2016-06-20 Thread Jeff King
On Mon, Jun 20, 2016 at 04:00:12PM -0400, Jeff King wrote: > You _should_ be able to get the right answer by asking git for > --date=local, but it doesn't seem to work. Looks like it is because our > tm_to_time_t hits this code: > > if (year < 0 || year > 129) /* algo only works for 1970-2099