Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-16 Thread Philip Oakley
From: brian m. carlson sand...@crustytoothpaste.net This series is designed to implement the changes necessary to build Git using Asciidoctor instead of AsciiDoc. [..] Even with these patches, Asciidoctor warns about everyday.txt and user-manual.txt. I'm not sending patches for these right

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-15 Thread Thomas Braun
Am 14.10.2014 um 11:51 schrieb Jeff King: What's the status on AsciiDoc versus AsciiDoctor? The latter seems more actively developed these days, but perhaps that is just my perception. The incompatibilities seem fairly minimal (if those first two patches are the extent of it, I have no problem

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-15 Thread Junio C Hamano
brian m. carlson sand...@crustytoothpaste.net writes: On Tue, Oct 14, 2014 at 10:08:19AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: On Sat, Oct 11, 2014 at 11:37:32PM +, brian m. carlson wrote: Specifically I'm not excited about getting into a state where we have

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-15 Thread brian m. carlson
On Wed, Oct 15, 2014 at 01:24:22PM +0200, Thomas Braun wrote: Am 14.10.2014 um 11:51 schrieb Jeff King: What's the status on AsciiDoc versus AsciiDoctor? The latter seems more actively developed these days, but perhaps that is just my perception. The incompatibilities seem fairly minimal

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-14 Thread Jakub Narębski
brian m. carlson wrote: On Mon, Oct 13, 2014 at 01:41:31PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: The second two patches implement some basic support for building with Asciidoctor. The first of these moves some items into variables due to some

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-14 Thread brian m. carlson
On Tue, Oct 14, 2014 at 12:07:51PM +0200, Jakub Narębski wrote: brian m. carlson wrote: On Mon, Oct 13, 2014 at 01:41:31PM -0700, Junio C Hamano wrote: What I do not understand is that 3/4 lets you drop inclusion of asciidoc.conf which contains a lot more than just linkgit: definition.

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-14 Thread Jeff King
On Sat, Oct 11, 2014 at 11:37:32PM +, brian m. carlson wrote: This series is designed to implement the changes necessary to build Git using Asciidoctor instead of AsciiDoc. Thanks. I had always taken the attitude that we wrote for the original Python AsciiDoc, and that using AsciiDoctor

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-14 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sat, Oct 11, 2014 at 11:37:32PM +, brian m. carlson wrote: Specifically I'm not excited about getting into a state where we have to maintain both an asciidoc.conf file _and_ ruby extensions for asciidoctor. I don't mind if somebody wants to step up and

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-14 Thread brian m. carlson
On Tue, Oct 14, 2014 at 10:08:19AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: On Sat, Oct 11, 2014 at 11:37:32PM +, brian m. carlson wrote: Specifically I'm not excited about getting into a state where we have to maintain both an asciidoc.conf file _and_ ruby

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-13 Thread Junio C Hamano
brian m. carlson sand...@crustytoothpaste.net writes: This series is designed to implement the changes necessary to build Git using Asciidoctor instead of AsciiDoc. The first two patches are bug fixes. Asciidoctor is stricter about title underline lengths (± 1 character instead of 2) and

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-13 Thread brian m. carlson
On Mon, Oct 13, 2014 at 01:41:31PM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: The second two patches implement some basic support for building with Asciidoctor. The first of these moves some items into variables due to some differences between the

[PATCH 0/4] Allow building Git with Asciidoctor

2014-10-11 Thread brian m. carlson
This series is designed to implement the changes necessary to build Git using Asciidoctor instead of AsciiDoc. The first two patches are bug fixes. Asciidoctor is stricter about title underline lengths (± 1 character instead of 2) and requires matching delimiter lengths[0]. They're needed