On 05/23/2015 01:34 AM, Michael Haggerty wrote:
verify_lock() is a helper function called while committing reference
transactions. But when it fails, instead of recording its error
message in a strbuf to be passed back to the caller of
ref_transaction_commit(), the error message was being
Michael Haggerty mhag...@alum.mit.edu writes:
The last sentence is nonsense. This patch series relies on
lock_ref_sha1_basic() having a strbuf *err parameter, which is only
the case since
4a32b2e lock_ref_sha1_basic(): report errors via a struct strbuf
*err (2015-05-11)
The latter
verify_lock() is a helper function called while committing reference
transactions. But when it fails, instead of recording its error
message in a strbuf to be passed back to the caller of
ref_transaction_commit(), the error message was being written directly
to stderr.
Instead, report the errors
On Fri, May 22, 2015 at 4:34 PM, Michael Haggerty mhag...@alum.mit.edu wrote:
verify_lock() is a helper function called while committing reference
transactions. But when it fails, instead of recording its error
message in a strbuf to be passed back to the caller of
ref_transaction_commit(),
4 matches
Mail list logo
