So here is an solution based on the write_file() is primarily to
produce text, so it should be able to correct the incomplete line
at the end approach.
The first one is Peff's idea to consolidate callers in am, in a
more concrete form.
The second is the fix to $gmane/276238.
The remainder is to
On Mon, Aug 24, 2015 at 10:09:41AM -0700, Junio C Hamano wrote:
So here is an solution based on the write_file() is primarily to
produce text, so it should be able to correct the incomplete line
at the end approach.
This all looks good to me. The topics-in-flight compatibility stuff in
On Mon, Aug 24, 2015 at 11:15:55AM -0700, Junio C Hamano wrote:
This all looks good to me. The topics-in-flight compatibility stuff in
patches 3 and 5 is neatly done. Usually I would just cheat and change
the order of arguments to make the compiler notice such problems, but
that's hard to
Jeff King p...@peff.net writes:
On Mon, Aug 24, 2015 at 10:09:41AM -0700, Junio C Hamano wrote:
So here is an solution based on the write_file() is primarily to
produce text, so it should be able to correct the incomplete line
at the end approach.
This all looks good to me. The
Jeff King p...@peff.net writes:
On Mon, Aug 24, 2015 at 11:15:55AM -0700, Junio C Hamano wrote:
This all looks good to me. The topics-in-flight compatibility stuff in
patches 3 and 5 is neatly done. Usually I would just cheat and change
the order of arguments to make the compiler notice
5 matches
Mail list logo
