Re: [PATCH 0/6] Create commit-graph file format v2

2019-01-25 Thread Derrick Stolee
On 1/24/2019 6:39 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> This series is based on ab/commit-graph-write-progress and bc/sha-256. > > Thanks. > > It seems that the base (i.e. merge between these two topics) you > used may have used a version of either topic (mo

Re: [PATCH 0/6] Create commit-graph file format v2

2019-01-24 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > This series is based on ab/commit-graph-write-progress and bc/sha-256. Thanks. It seems that the base (i.e. merge between these two topics) you used may have used a version of either topic (most likely the latter) slightly older than what I have, as p

Re: [PATCH 0/6] Create commit-graph file format v2

2019-01-24 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > The commit-graph file format has some shortcomings that were discussed > on-list: > ... > This series adds a new version (2) to the commit-graph file. Sigh. It is unfortunate that we have to bump the format version this early before we can say "it is

[PATCH 0/6] Create commit-graph file format v2

2019-01-23 Thread Derrick Stolee via GitGitGadget
The commit-graph file format has some shortcomings that were discussed on-list: 1. It doesn't use the 4-byte format ID from the_hash_algo. 2. There is no way to change the reachability index from generation numbers to corrected commit date [1]. 3. The unused byte in the