Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Stefan Beller
On Tue, Dec 13, 2016 at 12:09 PM, Stefan Beller wrote: > > So I will reroll it with "absorb" fixing some nits pointed out by David? I got confused there, Davids nits are for this series, the absorb series itself doesn't seem to have nits. So I'll just reroll this series on top of the currently s

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Stefan Beller
On Tue, Dec 13, 2016 at 11:47 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> The desired standard for submodules is to have the git dir inside the >> superprojects git dir (since 501770e, Aug 2011, Move git-dir for >> submodules), which is why I think an "embedded submodule git dir" >> i

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Junio C Hamano
Stefan Beller writes: > I guess the latter is the case, so embedding is actually inside > the working tree and un-embedding is the relocation to the > superproject. Another reason why I personally see a .git in each submodule working tree is "embedded" has nothing to do with Git. It is an analo

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Junio C Hamano
Stefan Beller writes: > The desired standard for submodules is to have the git dir inside the > superprojects git dir (since 501770e, Aug 2011, Move git-dir for > submodules), which is why I think an "embedded submodule git dir" > is inside the superproject already. Think how you start a new su

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Stefan Beller
On Tue, Dec 13, 2016 at 11:11 AM, Junio C Hamano wrote: > Stefan Beller writes: > >>> I do not think there is no dispute about what embedding means. >> >> double negative: You think we have a slight dispute here. > > Sorry, I do not think there is any dispute on that. > >>> A >>> submodule whose

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Stefan Beller
On Tue, Dec 13, 2016 at 11:13 AM, Stefan Beller wrote: > On Tue, Dec 13, 2016 at 11:11 AM, Junio C Hamano wrote: >> Stefan Beller writes: >> I do not think there is no dispute about what embedding means. >>> >>> double negative: You think we have a slight dispute here. >> >> Sorry, I do not

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Junio C Hamano
Stefan Beller writes: >> I do not think there is no dispute about what embedding means. > > double negative: You think we have a slight dispute here. Sorry, I do not think there is any dispute on that. >> A >> submodule whose .git is inside its working tree has its repository >> embedded. >> >

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Stefan Beller
On Tue, Dec 13, 2016 at 10:53 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Mon, Dec 12, 2016 at 11:28 PM, Junio C Hamano wrote: >>> Stefan Beller writes: >>> The "checkout --recurse-submodules" series got too large to comfortably send it out for review, so I had to

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Dec 12, 2016 at 11:28 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> The "checkout --recurse-submodules" series got too large to comfortably send >>> it out for review, so I had to break it up into smaller series'; this is the >>> first subseries, but

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-13 Thread Stefan Beller
On Mon, Dec 12, 2016 at 11:28 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The "checkout --recurse-submodules" series got too large to comfortably send >> it out for review, so I had to break it up into smaller series'; this is the >> first subseries, but it makes sense on its own. >> >

Re: [PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-12 Thread Junio C Hamano
Stefan Beller writes: > The "checkout --recurse-submodules" series got too large to comfortably send > it out for review, so I had to break it up into smaller series'; this is the > first subseries, but it makes sense on its own. > > This series teaches git-rm to absorb the git directory of a sub

[PATCH 0/6] git-rm absorbs submodule git directory before deletion

2016-12-12 Thread Stefan Beller
The "checkout --recurse-submodules" series got too large to comfortably send it out for review, so I had to break it up into smaller series'; this is the first subseries, but it makes sense on its own. This series teaches git-rm to absorb the git directory of a submodule instead of failing and com