Re: [PATCH 0/8] Better heuristics make prettier diffs

2016-08-04 Thread Jeff King
On Thu, Aug 04, 2016 at 12:54:51PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Not that you probably need more random cases of C code, but I happened > > to be looking at a diff in git.git today, b333d0d6, which is another > > regression for the compaction heuristic. > > Wow, that on

Re: [PATCH 0/8] Better heuristics make prettier diffs

2016-08-04 Thread Junio C Hamano
Jeff King writes: > Not that you probably need more random cases of C code, but I happened > to be looking at a diff in git.git today, b333d0d6, which is another > regression for the compaction heuristic. Wow, that one is _really_ bad. Does it have something to do with the removal being at the

Re: [PATCH 0/8] Better heuristics make prettier diffs

2016-08-04 Thread Jeff King
On Thu, Aug 04, 2016 at 12:00:28AM +0200, Michael Haggerty wrote: > I've talked about this quite a bit on the list already. The idea is to > improve ugly diffs like > > @@ -231,6 +231,9 @@ if (!defined $initial_reply_to && $prompting) { > } > > if (!$smtp_server) { > + $s

[PATCH 0/8] Better heuristics make prettier diffs

2016-08-03 Thread Michael Haggerty
I've talked about this quite a bit on the list already. The idea is to improve ugly diffs like @@ -231,6 +231,9 @@ if (!defined $initial_reply_to && $prompting) { } if (!$smtp_server) { + $smtp_server = $repo->config('sendemail.smtpserver'); +} +if (!$smtp_server)

Re: [PATCH 0/8] Better heuristics make prettier diffs

2016-08-03 Thread Michael Haggerty
On 08/04/2016 12:00 AM, Michael Haggerty wrote: > I've talked about this quite a bit on the list already. The idea is to > improve ugly diffs I forgot to note that this patch series is also available from my GitHub account [1] as branch "diff-indent-heuristics". Also, I will be away from my compu