Re: [PATCH 0/8] write_file cleanups

2016-07-08 Thread René Scharfe
Am 08.07.2016 um 11:04 schrieb Jeff King: Here it is. There actually weren't that many spots to clean up, as quite a few of them have a "twist" where they want to do something clever, like open the file and feed the descriptor to a sub-function, or open with funny things like O_EXCL. But still,

[PATCH 0/8] write_file cleanups

2016-07-08 Thread Jeff King
On Fri, Jul 08, 2016 at 02:56:50AM -0400, Jeff King wrote: > > This is more an illustration of unnecessarily duplicated code, isn't it? > > There are *tons* of instances in Git's code where writing to a file is > > implemented separately (and differently). > > > > It would make tons of sense to