Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

Hi Ævar, On Fri, 30 Mar 2018, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Mar 29 2018, Johannes Schindelin wrote: > > > Nonetheless, I would be confortable with this patch going into > > v2.17.0, even at this late stage. The final verdict is Junio's, of > > course. > > Thanks a lot for working

Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

On Thu, Mar 29 2018, Johannes Schindelin wrote: > Nonetheless, I would be confortable with this patch going into v2.17.0, even > at > this late stage. The final verdict is Junio's, of course. Thanks a lot for working on this. I'm keen to stress test this, but won't have time in the next few

Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

Hi Peff, On Thu, 29 Mar 2018, Jeff King wrote: > On Thu, Mar 29, 2018 at 05:18:30PM +0200, Johannes Schindelin wrote: > > > The first patch is somewhat of a "while at it" bug fix that I first > > thought would be a lot more critical than it actually is: It really > > only affects config files

Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

Hi Stefan, On Thu, 29 Mar 2018, Stefan Beller wrote: > On Thu, Mar 29, 2018 at 8:18 AM, Johannes Schindelin > wrote: > > > So what is the argument against this extra care to detect comments? Well, if > > you have something like this: > > > > [section] > >

Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

On Thu, Mar 29, 2018 at 05:18:30PM +0200, Johannes Schindelin wrote: > Little did I know that this would turn not only into a full patch to fix this > issue, but into a full-blown series of nine patches. It's amazing how often that happens. :) > The first patch is somewhat of a "while at it"

Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

On Thu, Mar 29, 2018 at 8:18 AM, Johannes Schindelin wrote: > So what is the argument against this extra care to detect comments? Well, if > you have something like this: > > [section] > ; Here we comment about the variable called snarf >

[PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

This patch series started out as a single patch trying to figure out what it takes to fix that annoying bug that has been reported several times over the years, where `git config --unset` would leave empty sections behind, and `git config --add` would not reuse them. Little did I know that this