Re: [PATCH 00/11] Moving global state into the repository object (part 2)

On Thu, Mar 1, 2018 at 2:09 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Wed, Feb 28, 2018 at 9:59 AM, Junio C Hamano wrote: >>> Duy Nguyen writes: >>> Looking at the full-series diff though, it

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

Hi, Stefan Beller wrote: > On Wed, Feb 28, 2018 at 9:57 AM, Junio C Hamano wrote: >> Wait a minute. Is that topic ever shown to work well together with >> other topics in flight and are now ready to be built upon? I had an >> impression that it is just starting to get

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

Stefan Beller writes: > On Wed, Feb 28, 2018 at 9:59 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> Looking at the full-series diff though, it makes me wonder if we >>> should keep prepare_packed_git() private (i.e. how we

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

On Wed, Feb 28, 2018 at 11:02 AM, Junio C Hamano wrote: > OK, so I finally picked up the last round, which wasn't even in my > private build. I had the previous round but hadn't convinced myself > that my conflict resolution with other topics in flight that were > still mushy

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

Junio C Hamano writes: > Stefan Beller writes: > >> This applies on top of origin/sb/object-store and is the continuation of >> that series, adding the repository as a context argument to functions. > > Wait a minute. Is that topic ever shown to work well

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

On Wed, Feb 28, 2018 at 9:59 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> Looking at the full-series diff though, it makes me wonder if we >> should keep prepare_packed_git() private (i.e. how we initialize the >> object store, packfile included, is a

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

On Wed, Feb 28, 2018 at 9:57 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> This applies on top of origin/sb/object-store and is the continuation of >> that series, adding the repository as a context argument to functions. > > Wait a minute. Is

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

Duy Nguyen writes: > Looking at the full-series diff though, it makes me wonder if we > should keep prepare_packed_git() private (i.e. how we initialize the > object store, packfile included, is a private matter). How about > something like this on top? Yup, that looks

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

Stefan Beller writes: > This applies on top of origin/sb/object-store and is the continuation of > that series, adding the repository as a context argument to functions. Wait a minute. Is that topic ever shown to work well together with other topics in flight and are now

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

On 2/27/2018 9:15 PM, Duy Nguyen wrote: On Tue, Feb 27, 2018 at 05:05:57PM -0800, Stefan Beller wrote: This applies on top of origin/sb/object-store and is the continuation of that series, adding the repository as a context argument to functions. This series focusses on packfile handling,

Re: [PATCH 00/11] Moving global state into the repository object (part 2)

On Tue, Feb 27, 2018 at 05:05:57PM -0800, Stefan Beller wrote: > This applies on top of origin/sb/object-store and is the continuation of > that series, adding the repository as a context argument to functions. > > This series focusses on packfile handling, exposing (re)prepare_packed_git > and

[PATCH 00/11] Moving global state into the repository object (part 2)

This applies on top of origin/sb/object-store and is the continuation of that series, adding the repository as a context argument to functions. This series focusses on packfile handling, exposing (re)prepare_packed_git and find_pack_entry to a repository argument. Looking at the diffstat of