Re: [PATCH 00/12] Die commit->util, die!

2018-05-22 Thread Stefan Beller
On Sat, May 12, 2018 at 1:00 AM, Nguyễn Thái Ngọc Duy wrote: > There's not much to write here. It's basically a copy from 12/12: > > This 'util' pointer can be used for many different purposes, > controlled in different ways. Some are not even contained in a command > code, but

Re: [PATCH 00/12] Die commit->util, die!

2018-05-12 Thread Duy Nguyen
On Sat, May 12, 2018 at 8:50 PM, Jakub Narebski wrote: > I just wonder if most of those transformation could not be done with > Coccinelle, instead of doing it by hand. I doubt coccinelle is smart enough to figure out the convoluted use of 'util' pointer (but then I'm not a

Re: [PATCH 00/12] Die commit->util, die!

2018-05-12 Thread Jakub Narebski
Nguyễn Thái Ngọc Duy writes: > There's not much to write here. It's basically a copy from 12/12: > > This 'util' pointer can be used for many different purposes, > controlled in different ways. Some are not even contained in a command > code, but buried deep in common code

Re: [PATCH 00/12] Die commit->util, die!

2018-05-12 Thread Jeff King
On Sat, May 12, 2018 at 10:00:16AM +0200, Nguyễn Thái Ngọc Duy wrote: > There's not much to write here. It's basically a copy from 12/12: > > This 'util' pointer can be used for many different purposes, > controlled in different ways. Some are not even contained in a command > code, but buried

[PATCH 00/12] Die commit->util, die!

2018-05-12 Thread Nguyễn Thái Ngọc Duy
There's not much to write here. It's basically a copy from 12/12: This 'util' pointer can be used for many different purposes, controlled in different ways. Some are not even contained in a command code, but buried deep in common code with no clue who will use it and how. For example, if