Re: [PATCH 00/15] Kill the_index part 1, expose it

2018-06-19 Thread Ben Peart
On 6/18/2018 2:41 PM, Brandon Williams wrote: On 06/17, Duy Nguyen wrote: On Sun, Jun 17, 2018 at 9:02 AM Elijah Newren wrote: On Fri, Jun 15, 2018 at 10:41 PM, Nguyễn Thái Ngọc Duy wrote: This is the beginning of the end of the_index. The problem with the_index is it lets library code

Re: [PATCH 00/15] Kill the_index part 1, expose it

2018-06-19 Thread Duy Nguyen
On Tue, Jun 19, 2018 at 1:48 PM Derrick Stolee wrote: > Personally, > I find it difficult to base a patch off of multiple in-progress branches > and would rather work off of a "known good" point like the tip of master. You should always base your patches on 'master' (or even 'maint' if it's bug

Re: [PATCH 00/15] Kill the_index part 1, expose it

2018-06-19 Thread Derrick Stolee
On 6/16/2018 1:41 AM, Nguyễn Thái Ngọc Duy wrote: This is the beginning of the end of the_index. The problem with the_index is it lets library code anywhere access it freely. This is not good because from high level you may not realize that the_index is being used while you don't want to touch

Re: [PATCH 00/15] Kill the_index part 1, expose it

2018-06-18 Thread Brandon Williams
On 06/17, Duy Nguyen wrote: > On Sun, Jun 17, 2018 at 9:02 AM Elijah Newren wrote: > > > > On Fri, Jun 15, 2018 at 10:41 PM, Nguyễn Thái Ngọc Duy > > wrote: > > > This is the beginning of the end of the_index. The problem with > > > the_index is it lets library code anywhere access it freely.

Re: [PATCH 00/15] Kill the_index part 1, expose it

2018-06-17 Thread Duy Nguyen
On Sun, Jun 17, 2018 at 9:02 AM Elijah Newren wrote: > > On Fri, Jun 15, 2018 at 10:41 PM, Nguyễn Thái Ngọc Duy > wrote: > > This is the beginning of the end of the_index. The problem with > > the_index is it lets library code anywhere access it freely. This is > > not good because from high

Re: [PATCH 00/15] Kill the_index part 1, expose it

2018-06-17 Thread Elijah Newren
On Fri, Jun 15, 2018 at 10:41 PM, Nguyễn Thái Ngọc Duy wrote: > This is the beginning of the end of the_index. The problem with > the_index is it lets library code anywhere access it freely. This is > not good because from high level you may not realize that the_index is > being used while you

[PATCH 00/15] Kill the_index part 1, expose it

2018-06-15 Thread Nguyễn Thái Ngọc Duy
This is the beginning of the end of the_index. The problem with the_index is it lets library code anywhere access it freely. This is not good because from high level you may not realize that the_index is being used while you don't want to touch index at all, or you want to use a different index