Re: [PATCH 00/27] nd/shallow-deepen updates

On Tue, Jun 14, 2016 at 12:10 AM, Junio C Hamano wrote: > Eric Sunshine writes: > >> I agree with Junio that moving the sigchain_pop() into the error >> handling code-path, if possible, would be a nice improvement. > > Yeah, "if possible" is really

Re: [PATCH 00/27] nd/shallow-deepen updates

Eric Sunshine writes: > I agree with Junio that moving the sigchain_pop() into the error > handling code-path, if possible, would be a nice improvement. Yeah, "if possible" is really what I was not sure about---is it safe to do the _push() thing before start_command(),

Re: [PATCH 00/27] nd/shallow-deepen updates

On Fri, Jun 10, 2016 at 8:26 AM, Nguyễn Thái Ngọc Duy wrote: > This contains cleanups after Eric's comments (all good points, > thanks!). Changed patches have Junio's s-o-b line removed, so it's > easy to see which is changed and which is not. 09/27 is a new one, > split out of

[PATCH 00/27] nd/shallow-deepen updates

This contains cleanups after Eric's comments (all good points, thanks!). Changed patches have Junio's s-o-b line removed, so it's easy to see which is changed and which is not. 09/27 is a new one, split out of 10/27. Interdiff diff --git a/builtin/clone.c b/builtin/clone.c index 5ccf6b7..3849231