Re: [PATCH 00/27] sb/object-store updates

Junio C Hamano writes: > Stefan Beller writes: > >> Thanks for driving this when I was away! >> >> With the fixup patch, both series are >> Reviewed-by: Stefan Beller > > I think everybody involved agrees that these two you cited above

Re: [PATCH 00/27] sb/object-store updates

Stefan Beller writes: > Thanks for driving this when I was away! > > With the fixup patch, both series are > Reviewed-by: Stefan Beller I think everybody involved agrees that these two you cited above are already in good shape. Let's have them in 'next'

Re: [PATCH 00/27] sb/object-store updates

On Fri, Mar 23, 2018 at 10:31 PM Duy Nguyen wrote: > I got too excited when searching and replacing. Here's the fixup > patch. Thanks for picking up the series that I left unattended over the last weeks. I have reviewed nd/remove-ignore-env-field as well as sb/object-store as

Re: [PATCH 00/27] sb/object-store updates

On Fri, Mar 23, 2018 at 06:07:33PM -0400, Eric Sunshine wrote: > On Fri, Mar 23, 2018 at 1:20 PM, Nguyễn Thái Ngọc Duy > wrote: > > Interdiff is big due to the "objects." to "objects->" conversion > > (blame Brandon for his suggestion, don't blame me :D) > > > > diff --git

Re: [PATCH 00/27] sb/object-store updates

On Fri, Mar 23, 2018 at 1:20 PM, Nguyễn Thái Ngọc Duy wrote: > Interdiff is big due to the "objects." to "objects->" conversion > (blame Brandon for his suggestion, don't blame me :D) > > diff --git a/packfile.c b/packfile.c > @@ -1938,7 +1939,7 @@ static int

Re: [PATCH 00/27] sb/object-store updates

Brandon Williams writes: >> > Interdiff is big due to the "objects." to "objects->" conversion >> > (blame Brandon for his suggestion, don't blame me :D) >> >> Haha, I'm guessing you prefer having a pointer too then? :P >> >> The interdiff looks good, though I'll set some

Re: [PATCH 00/27] sb/object-store updates

On Fri, Mar 23, 2018 at 7:35 PM, Brandon Williams wrote: > On 03/23, Nguyễn Thái Ngọc Duy wrote: >> I think I have addressed all comments I've received so far. What I >> decided not to do, I have responded individually. One comment I did >> not respond nor do is the approximate

Re: [PATCH 00/27] sb/object-store updates

On 03/23, Brandon Williams wrote: > On 03/23, Nguyễn Thái Ngọc Duy wrote: > > I think I have addressed all comments I've received so far. What I > > decided not to do, I have responded individually. One comment I did > > not respond nor do is the approximate thing, which could be done > > later. >

Re: [PATCH 00/27] sb/object-store updates

On 03/23, Nguyễn Thái Ngọc Duy wrote: > I think I have addressed all comments I've received so far. What I > decided not to do, I have responded individually. One comment I did > not respond nor do is the approximate thing, which could be done > later. > > Interdiff is big due to the "objects."

[PATCH 00/27] sb/object-store updates

I think I have addressed all comments I've received so far. What I decided not to do, I have responded individually. One comment I did not respond nor do is the approximate thing, which could be done later. Interdiff is big due to the "objects." to "objects->" conversion (blame Brandon for his