Re: [PATCH 00/41] object_id part 13

2018-05-01 Thread Duy Nguyen
On Mon, Apr 30, 2018 at 11:59:43PM +, brian m. carlson wrote: > > I guess I'll be helping review this series instead :D Overall I think this looks good. > > Yeah, I have code to fix that, but it's ugly. > > You can see the work on part2 and part3 of the test fixes, plus the > fixes for all

Re: [PATCH 00/41] object_id part 13

2018-04-30 Thread brian m. carlson
On Mon, Apr 30, 2018 at 08:03:12PM +0200, Duy Nguyen wrote: > On Tue, Apr 24, 2018 at 1:39 AM, brian m. carlson > wrote: > > [0] I can synthesize blobs, trees, and commits, but things are currently > > totally broken, which is, I suppose, to be expected. > > Yup. I

Re: [PATCH 00/41] object_id part 13

2018-04-30 Thread Duy Nguyen
On Tue, Apr 24, 2018 at 1:39 AM, brian m. carlson wrote: > [0] I can synthesize blobs, trees, and commits, but things are currently > totally broken, which is, I suppose, to be expected. Yup. I was tired and bored so I went playing with the new hash. Writing and

[PATCH 00/41] object_id part 13

2018-04-23 Thread brian m. carlson
This is the thirteenth series of patches to convert to struct object_id and the_hash_algo. The series adds an oidread function to read object IDs from a buffer, removes unused structure members (which therefore don't require conversion), converts various functions to struct object_id, and