Christian Couder writes:
> There is also a new version of my 86 patch long series to replace
> prefixcmp() with starts_with() that I am ready to send, but I hesitate
> to spam the whole list :-)
> I can put it somewhere like GitHub where people can see everything and
> perhaps send only a few pat
On Sun, Nov 17, 2013 at 9:52 AM, Christian Couder
wrote:
> From: Jeff King
>>
>> On Wed, Nov 13, 2013 at 07:47:03AM +0100, Christian Couder wrote:
>>
>>> My preference is:
>>>
>>> 1) with an "s"
>>> 2) "start"
>>> 3) underscore
>>>
>>> so that gives: starts_with() and ends_with()
>>
>> FWIW, that
From: Jeff King
>
> On Wed, Nov 13, 2013 at 07:47:03AM +0100, Christian Couder wrote:
>
>> My preference is:
>>
>> 1) with an "s"
>> 2) "start"
>> 3) underscore
>>
>> so that gives: starts_with() and ends_with()
>
> FWIW, that looks good to me, too. Whether there is confusion over the
> meanin
On Wed, Nov 13, 2013 at 07:47:03AM +0100, Christian Couder wrote:
> My preference is:
>
> 1) with an "s"
> 2) "start"
> 3) underscore
>
> so that gives: starts_with() and ends_with()
FWIW, that looks good to me, too. Whether there is confusion over the
meaning of "suffix" or not, it makes sense
From: Junio C Hamano
>
> Christian Couder writes:
>>
>> After a look at some languages, Python has "startwith()" and
>> "endswith()", and Java has "startWith()" and "endsWith()".
>>
>> But while we are at it, why not
>> "ends_with()" and "begins_with()"? To me using an underscore seems
>> more c
Christian Couder writes:
> From: Junio C Hamano
>>
>> Even though we already added has_suffix() for tail matches, it is
>> not too late to rethink, as it is not in 'master' yet.
>>
>> One thing I noticed is that it is probably misnamed, or at least in
>> a way that invites confusion. Can peop
From: Junio C Hamano
>
> Even though we already added has_suffix() for tail matches, it is
> not too late to rethink, as it is not in 'master' yet.
>
> One thing I noticed is that it is probably misnamed, or at least in
> a way that invites confusion. Can people tell which one of these is
> cor
On Tue, Nov 12, 2013 at 08:53:45AM -0800, Junio C Hamano wrote:
> Even though we already added has_suffix() for tail matches, it is
> not too late to rethink, as it is not in 'master' yet.
>
> One thing I noticed is that it is probably misnamed, or at least in
> a way that invites confusion. Can
Jeff King writes:
> I am ambivalent on the code churn, but if we do apply it, we should
> probably leave off the final patch (dropping prefixcmp) for a cycle to
> let topics in flight catch up to the change. Just diffing "master" and
> "next", I see some new uses of prefixcmp which will need adju
On Mon, Nov 11, 2013 at 05:09:17PM +0100, Andreas Ericsson wrote:
> On 2013-11-09 08:05, Christian Couder wrote:
> >Here is a big patch series to replace prefixcmp() with a new
> >has_prefix() function.
> >
>
> Seems like totally useless codechurn to me. Besides, prefixcmp()
> ties in nicely with
On Sat, Nov 9, 2013 at 3:24 PM, Thomas Rast wrote:
> Christian Couder writes:
>
>> Christian Couder (86):
>> strbuf: add has_prefix() to be used instead of prefixcmp()
>> diff: replace prefixcmd() with has_prefix()
>> fast-import: replace prefixcmd() with has_prefix()
> [...]
>> builtin/u
On 2013-11-09 08:05, Christian Couder wrote:
Here is a big patch series to replace prefixcmp() with a new
has_prefix() function.
Seems like totally useless codechurn to me. Besides, prefixcmp()
ties in nicely with strcmp() and memcmp() (and returns 0 on a
match just like its namesakes), wherea
Christian Couder writes:
> Christian Couder (86):
> strbuf: add has_prefix() to be used instead of prefixcmp()
> diff: replace prefixcmd() with has_prefix()
> fast-import: replace prefixcmd() with has_prefix()
[...]
> builtin/update-ref: replace prefixcmd() with has_prefix()
> builtin/u
Here is a big patch series to replace prefixcmp() with a new
has_prefix() function.
So the first patch of this series introduces has_prefix()
and the last patch removes prefixcmp().
Except in a few cases, I used a script that does basically
the following to generate the commits in between:
===
#
14 matches
Mail list logo