Re: [PATCH 01/13] dir: allow exclusions from blob in addition to file

2017-10-26 Thread Jeff Hostetler
On 10/25/2017 11:47 PM, Junio C Hamano wrote: Jeff Hostetler writes: The existing code handles use cases where you want to read the exclusion list from a pathname in the worktree -- or from blob named in the index when the pathname is not populated (presumably

Re: [PATCH 01/13] dir: allow exclusions from blob in addition to file

2017-10-25 Thread Junio C Hamano
Jeff Hostetler writes: > The existing code handles use cases where you want to read the > exclusion list from a pathname in the worktree -- or from blob > named in the index when the pathname is not populated (presumably > because of the skip-worktree bit). > > I was

Re: [PATCH 01/13] dir: allow exclusions from blob in addition to file

2017-10-25 Thread Jeff Hostetler
On 10/25/2017 2:43 AM, Junio C Hamano wrote: Jeff Hostetler writes: +static int add_excludes_from_buffer(char *buf, size_t size, + const char *base, int baselen, + struct exclude_list *el); + /*

Re: [PATCH 01/13] dir: allow exclusions from blob in addition to file

2017-10-25 Thread Junio C Hamano
Jeff Hostetler writes: > +static int add_excludes_from_buffer(char *buf, size_t size, > + const char *base, int baselen, > + struct exclude_list *el); > + > /* > * Given a file with name "fname", read it

Re: [PATCH 01/13] dir: allow exclusions from blob in addition to file

2017-10-24 Thread Eric Sunshine
On Tue, Oct 24, 2017 at 2:53 PM, Jeff Hostetler wrote: > Refactor add_excludes() to separate the reading of the > exclude file into a buffer and the parsing of the buffer > into exclude_list items. > > Add add_excludes_from_blob_to_list() to allow an exclude > file be

[PATCH 01/13] dir: allow exclusions from blob in addition to file

2017-10-24 Thread Jeff Hostetler
From: Jeff Hostetler Refactor add_excludes() to separate the reading of the exclude file into a buffer and the parsing of the buffer into exclude_list items. Add add_excludes_from_blob_to_list() to allow an exclude file be specified with an OID. Signed-off-by: Jeff