Re: [PATCH 01/13] repository: introduce object parser field

2018-05-02 Thread Jonathan Tan
On Tue, 1 May 2018 14:33:51 -0700 Stefan Beller wrote: > Git's object access code can be thought of as containing two layers: > the raw object store provides access to raw object content, while the > higher level obj_hash code parses raw objects and keeps track of >

Re: [PATCH 01/13] repository: introduce object parser field

2018-05-02 Thread Duy Nguyen
On Wed, May 2, 2018 at 7:26 PM, Stefan Beller wrote: >> Another suggestion is object_pool, if we keep 'struct object' instead >> of 'struct parsed_object' and also want to keep current allocation >> behavior: no individual deallocation. If you free, you free the whole >> pool

Re: [PATCH 01/13] repository: introduce object parser field

2018-05-02 Thread Stefan Beller
On Wed, May 2, 2018 at 10:17 AM, Duy Nguyen wrote: > On Tue, May 1, 2018 at 11:33 PM, Stefan Beller wrote: >> /* >> -* Holds any information related to accessing the raw object content. >> +* Holds any information needed to retrieve

Re: [PATCH 01/13] repository: introduce object parser field

2018-05-02 Thread Duy Nguyen
On Tue, May 1, 2018 at 11:33 PM, Stefan Beller wrote: > /* > -* Holds any information related to accessing the raw object content. > +* Holds any information needed to retrieve the raw content > +* of objects. The object_parser uses this to get

[PATCH 01/13] repository: introduce object parser field

2018-05-01 Thread Stefan Beller
Git's object access code can be thought of as containing two layers: the raw object store provides access to raw object content, while the higher level obj_hash code parses raw objects and keeps track of parenthood and other object relationships using 'struct object'. Keeping these layers separate