Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros

2018-07-23 Thread SZEDER Gábor
On Tue, Jun 19, 2018 at 5:21 PM Derrick Stolee wrote: > > On 6/19/2018 10:51 AM, Duy Nguyen wrote: > > Do we run 'make coccicheck' > > automatically somewhere? If true, I need to move this script elsewhere > > because it's meant to run manually. You run it when you intend to do > > more manual

Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros

2018-06-19 Thread Derrick Stolee
On 6/19/2018 10:51 AM, Duy Nguyen wrote: On Tue, Jun 19, 2018 at 1:41 PM Derrick Stolee wrote: Duy, Here is the patch that was generated by `make coccicheck`. Thanks, -Stolee -->8-- --- builtin/add.c Ah right. This is on purpose. I think I mentioned in the commit message that builtin/ is

Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros

2018-06-19 Thread Duy Nguyen
On Tue, Jun 19, 2018 at 1:41 PM Derrick Stolee wrote: > > Duy, > > Here is the patch that was generated by `make coccicheck`. > > Thanks, > -Stolee > > -->8-- > > --- builtin/add.c Ah right. This is on purpose. I think I mentioned in the commit message that builtin/ is not touched. Do we run

Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros

2018-06-19 Thread Derrick Stolee
Duy, Here is the patch that was generated by `make coccicheck`. Thanks, -Stolee -->8-- --- builtin/add.c +++ /tmp/cocci-output-206193-4c91ec-add.c @@ -38,13 +38,13 @@ static void chmod_pathspec(struct pathsp { int i; - for (i = 0; i < active_nr; i++) { - struct

Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros

2018-06-19 Thread Derrick Stolee
On 6/16/2018 1:41 AM, Nguyễn Thái Ngọc Duy wrote: Index compat macros are going to be removed to expose the_index and then reorganized to use the right index instead of simply the_index because sometimes we want to use a different index. This cocci script can help with the first step. It can be

[PATCH 01/15] contrib: add cocci script to replace index compat macros

2018-06-15 Thread Nguyễn Thái Ngọc Duy
Index compat macros are going to be removed to expose the_index and then reorganized to use the right index instead of simply the_index because sometimes we want to use a different index. This cocci script can help with the first step. It can be used later on on even builtin/ when we start to