Re: [PATCH 01/15] handle_revision_arg: reset "dotdot" consistently

From: "Jeff King" On Sat, May 20, 2017 at 03:56:32PM +0100, Philip Oakley wrote: > That means we do report the correct name for "a" in the > pending array. But some code paths try to show the whole > "a..b" name in error messages, and these erroneously show > only "a" instead

Re: [PATCH 01/15] handle_revision_arg: reset "dotdot" consistently

On Sat, May 20, 2017 at 03:56:32PM +0100, Philip Oakley wrote: > > That means we do report the correct name for "a" in the > > pending array. But some code paths try to show the whole > > "a..b" name in error messages, and these erroneously show > > only "a" instead of "a..b". E.g.: > > > > $

Re: [PATCH 01/15] handle_revision_arg: reset "dotdot" consistently

From: "Jeff King" When we are parsing a range like "a..b", we write a temporary NUL over the first ".", so that we can access the names "a" and "b" as C strings. But our restoration of the original "." is done at inconsistent times, which can lead to confusing results. For most

[PATCH 01/15] handle_revision_arg: reset "dotdot" consistently

When we are parsing a range like "a..b", we write a temporary NUL over the first ".", so that we can access the names "a" and "b" as C strings. But our restoration of the original "." is done at inconsistent times, which can lead to confusing results. For most calls, we restore the "." after we