Célestin Matte celestin.ma...@ensimag.fr writes:
Subject: [PATCH 01/18] Follow perlcritic's recommendations - level 5 and 4
It would be better to prefix commit messages with git-remote-mediawiki: .
Fix warnings from perlcritic's level 5 and 4.
It would be cool to have a make perlcritic
Le 07/06/2013 10:10, Matthieu Moy a écrit :
It would be cool to have a make perlcritic target in the Makefile so
that future developers can easily re-run it and avoid repeating the same
mistakes. As much as possible, make perlcritic should produce no
output at the end of your patch series
Célestin Matte celestin.ma...@ensimag.fr writes:
The problem is that I took some policies into account for some parts of
the code, but not for all of it. For instance, in commit [15/18], I put
some numeric values in constants, but not all of them, as I think having
arg[3] in the code does
Fix warnings from perlcritic's level 5 and 4. They correspond to the following
cases:
- always end a submodule with a return
- don't use the constant pragma, use the Readonly module instead
- some syntax details for maps, and others.
Signed-off-by: Célestin Matte celestin.ma...@ensimag.fr
On Thu, Jun 6, 2013 at 3:34 PM, Célestin Matte
celestin.ma...@ensimag.fr wrote:
Fix warnings from perlcritic's level 5 and 4. They correspond to the following
cases:
- always end a submodule with a return
- don't use the constant pragma, use the Readonly module instead
- some syntax details
5 matches
Mail list logo
