Re: [PATCH 01/23] t3600: clean up permissions test properly

2017-05-18 Thread Michael Haggerty
On 05/18/2017 06:10 AM, Junio C Hamano wrote: > Michael Haggerty writes: > >> The test of failing `git rm -f` removes the write permissions on the >> test directory, but fails to restore them if the test fails. This >> means that the test temporary directory cannot be

Re: [PATCH 01/23] t3600: clean up permissions test properly

2017-05-17 Thread Junio C Hamano
Michael Haggerty writes: > The test of failing `git rm -f` removes the write permissions on the > test directory, but fails to restore them if the test fails. This > means that the test temporary directory cannot be cleaned up, which > means that subsequent attempts to run

Re: [PATCH 01/23] t3600: clean up permissions test properly

2017-05-17 Thread Michael Haggerty
On 05/17/2017 02:42 PM, Jeff King wrote: > On Wed, May 17, 2017 at 02:05:24PM +0200, Michael Haggerty wrote: > >> The test of failing `git rm -f` removes the write permissions on the >> test directory, but fails to restore them if the test fails. This >> means that the test temporary directory

Re: [PATCH 01/23] t3600: clean up permissions test properly

2017-05-17 Thread Jeff King
On Wed, May 17, 2017 at 02:05:24PM +0200, Michael Haggerty wrote: > The test of failing `git rm -f` removes the write permissions on the > test directory, but fails to restore them if the test fails. This > means that the test temporary directory cannot be cleaned up, which > means that

[PATCH 01/23] t3600: clean up permissions test properly

2017-05-17 Thread Michael Haggerty
The test of failing `git rm -f` removes the write permissions on the test directory, but fails to restore them if the test fails. This means that the test temporary directory cannot be cleaned up, which means that subsequent attempts to run the test fail mysteriously. Instead, do the cleanup in a