Re: [PATCH 01/25] t/test-lib: introduce --chain-lint option

2015-03-24 Thread Jeff King
On Wed, Mar 25, 2015 at 03:53:52AM +0100, SZEDER Gábor wrote: cmd1 for i in a b c; do cmd2 $i done cmd3 which will not notice failures of cmd2 a or cmd b s/cmd b/cmd2 b/ ? Yes, but the patches are already in next, so it is sadly too late for commit

Re: [PATCH 01/25] t/test-lib: introduce --chain-lint option

2015-03-24 Thread SZEDER Gábor
Quoting Jeff King p...@peff.net: However, there are a number of places it cannot reach: - it cannot find a failure to break out of loops on error, like: cmd1 for i in a b c; do cmd2 $i done cmd3 which will not notice failures of cmd2 a or cmd b

[PATCH 01/25] t/test-lib: introduce --chain-lint option

2015-03-20 Thread Jeff King
It's easy to miss an -chain in a test script, like: test_expect_success 'check something important' ' cmd1 cmd2 cmd3 ' The test harness will notice if cmd3 fails, but a failure of cmd1 or cmd2 will go unnoticed, as their exit status is lost after cmd3 runs. The toy