Re: [PATCH 02/11] http-backend.c: replace `git_config()` with `git_config_get_bool()` family

2014-08-06 Thread Eric Sunshine
On Wed, Aug 6, 2014 at 11:44 AM, Matthieu Moy wrote: > Tanay Abhra writes: > >> On 8/5/2014 12:29 AM, Eric Sunshine wrote: >>> On Mon, Aug 4, 2014 at 2:33 PM, Tanay Abhra wrote: - if (skip_prefix(var, "http.", &p)) { - int i; - - for (i = 0;

Re: [PATCH 02/11] http-backend.c: replace `git_config()` with `git_config_get_bool()` family

2014-08-06 Thread Matthieu Moy
Tanay Abhra writes: > On 8/5/2014 12:29 AM, Eric Sunshine wrote: >> On Mon, Aug 4, 2014 at 2:33 PM, Tanay Abhra wrote: >>> - if (skip_prefix(var, "http.", &p)) { >>> - int i; >>> - >>> - for (i = 0; i < ARRAY_SIZE(rpc_service); i++) { >>> -

Re: [PATCH 02/11] http-backend.c: replace `git_config()` with `git_config_get_bool()` family

2014-08-06 Thread Tanay Abhra
On 8/5/2014 12:29 AM, Eric Sunshine wrote: > On Mon, Aug 4, 2014 at 2:33 PM, Tanay Abhra wrote: >> Use `git_config_get_bool()` family instead of `git_config()` to take >> advantage of >> the config-set API which provides a cleaner control flow. >> >> Signed-off-by: Tanay Abhra >> --- >> http-

Re: [PATCH 02/11] http-backend.c: replace `git_config()` with `git_config_get_bool()` family

2014-08-04 Thread Eric Sunshine
On Mon, Aug 4, 2014 at 2:33 PM, Tanay Abhra wrote: > Use `git_config_get_bool()` family instead of `git_config()` to take > advantage of > the config-set API which provides a cleaner control flow. > > Signed-off-by: Tanay Abhra > --- > http-backend.c | 31 --- > 1 fi

[PATCH 02/11] http-backend.c: replace `git_config()` with `git_config_get_bool()` family

2014-08-04 Thread Tanay Abhra
Use `git_config_get_bool()` family instead of `git_config()` to take advantage of the config-set API which provides a cleaner control flow. Signed-off-by: Tanay Abhra --- http-backend.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/http-ba