Re: [PATCH 02/15] read-cache: Improve readability

Stefan Beller writes: > Maybe I have read too much of the refs code lately as there we > have these long chains which combine precondition with error > checking. Of course, things are not so black-and-white in the real world. You can also take an extreme stance and view if (!pretend

Re: [PATCH 02/15] read-cache: Improve readability

On Fri, Mar 20, 2015 at 9:19 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Signed-off-by: Stefan Beller >> --- >> read-cache.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/read-cache.c b/read-cache.c >> index f72ea9f..769897e 100644 >> --- a/read-cache

Re: [PATCH 02/15] read-cache: Improve readability

Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > read-cache.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/read-cache.c b/read-cache.c > index f72ea9f..769897e 100644 > --- a/read-cache.c > +++ b/read-cache.c > @@ -703,9 +703,7 @@ int add_to_index(stru

[PATCH 02/15] read-cache: Improve readability

Signed-off-by: Stefan Beller --- read-cache.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/read-cache.c b/read-cache.c index f72ea9f..769897e 100644 --- a/read-cache.c +++ b/read-cache.c @@ -703,9 +703,7 @@ int add_to_index(struct index_state *istate, const char *path,