Re: [PATCH 03/10] fast-export: use value from correct enum

2018-11-12 Thread Jeff King
On Sun, Nov 11, 2018 at 09:10:17PM +0100, Ævar Arnfjörð Bjarmason wrote: > > This is a good argument for naming these SIGNED_TAG_ABORT, etc. But this > > is obviously an improvement in the meantime. > > In C enum values aren't the types of the enum, but I'd thought someone > would have added a

Re: [PATCH 03/10] fast-export: use value from correct enum

2018-11-12 Thread Ævar Arnfjörð Bjarmason
On Sun, Nov 11, 2018 at 9:10 PM Ævar Arnfjörð Bjarmason wrote: > > > On Sun, Nov 11 2018, Jeff King wrote: > > > On Sat, Nov 10, 2018 at 10:23:05PM -0800, Elijah Newren wrote: > > > >> ABORT and ERROR happen to have the same value, but come from differnt > >> enums. Use the one from the correct

Re: [PATCH 03/10] fast-export: use value from correct enum

2018-11-11 Thread Ævar Arnfjörð Bjarmason
On Sun, Nov 11 2018, Jeff King wrote: > On Sat, Nov 10, 2018 at 10:23:05PM -0800, Elijah Newren wrote: > >> ABORT and ERROR happen to have the same value, but come from differnt >> enums. Use the one from the correct enum. > > Yikes. :) > > This is a good argument for naming these

Re: [PATCH 03/10] fast-export: use value from correct enum

2018-11-10 Thread Jeff King
On Sat, Nov 10, 2018 at 10:23:05PM -0800, Elijah Newren wrote: > ABORT and ERROR happen to have the same value, but come from differnt > enums. Use the one from the correct enum. Yikes. :) This is a good argument for naming these SIGNED_TAG_ABORT, etc. But this is obviously an improvement in

[PATCH 03/10] fast-export: use value from correct enum

2018-11-10 Thread Elijah Newren
ABORT and ERROR happen to have the same value, but come from differnt enums. Use the one from the correct enum. Signed-off-by: Elijah Newren --- builtin/fast-export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/fast-export.c b/builtin/fast-export.c index