Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

2014-03-25 Thread Johannes Sixt
Am 24.03.2014 22:39, schrieb Jeff King: On Mon, Mar 24, 2014 at 05:36:59PM -0400, Jeff King wrote: +How to write RIGHT test cases += + +Insert the word ChangeMe (exactly this form) at a distance of +at least two lines from the line that must appear in the hunk

Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

2014-03-24 Thread Jeff King
On Fri, Mar 21, 2014 at 10:07:15PM +0100, Johannes Sixt wrote: Add an infrastructure that simplifies adding new tests of the hunk header regular expressions. To add new tests, a file with the syntax to test can be dropped in the directory t4018. The README file explains how a test file must

Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

2014-03-24 Thread Jeff King
On Mon, Mar 24, 2014 at 05:36:59PM -0400, Jeff King wrote: +How to write RIGHT test cases += + +Insert the word ChangeMe (exactly this form) at a distance of +at least two lines from the line that must appear in the hunk header. The existing tests use -U1

Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

2014-03-23 Thread Junio C Hamano
Johannes Sixt j...@kdbg.org writes: I see what you mean. Notice, however, that we also test whether the regular expressions can be compiled successfully, and for this it is desirable to have the complete list of userdiff drivers. Until we have at least one test-case for each driver, we

Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

2014-03-22 Thread Johannes Sixt
Am 21.03.2014 23:00, schrieb Junio C Hamano: Johannes Sixt j...@kdbg.org writes: Add an infrastructure that simplifies adding new tests of the hunk header regular expressions. To add new tests, a file with the syntax to test can be dropped in the directory t4018. The README file explains

[PATCH 03/10] t4018: an infrastructure to test hunk headers

2014-03-21 Thread Johannes Sixt
Add an infrastructure that simplifies adding new tests of the hunk header regular expressions. To add new tests, a file with the syntax to test can be dropped in the directory t4018. The README file explains how a test file must contain; the README itself tests the default behavior.

Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

2014-03-21 Thread Junio C Hamano
Johannes Sixt j...@kdbg.org writes: Add an infrastructure that simplifies adding new tests of the hunk header regular expressions. To add new tests, a file with the syntax to test can be dropped in the directory t4018. The README file explains how a test file must contain; s/how/what/, or