Re: [PATCH 03/11] packfile: allow install_packed_git to handle arbitrary repositories

2018-02-28 Thread Derrick Stolee
On 2/27/2018 8:06 PM, Stefan Beller wrote: -void install_packed_git(struct packed_git *pack) +void install_packed_git(struct repository *r, struct packed_git *pack) This is a good thing to do. I'm just making note that this will collide with the new instances of install_packed_git() that I

[PATCH 03/11] packfile: allow install_packed_git to handle arbitrary repositories

2018-02-27 Thread Stefan Beller
This conversion was done without the #define trick used in the earlier series refactoring to have better repository access, because this function is easy to review, as it only has one caller and all lines but the first two are converted. We must not convert 'pack_open_fds' to be a repository