Re: [PATCH 03/12] t: drop useless sane_unset GIT_* calls

2014-03-24 Thread Jeff King
On Fri, Mar 21, 2014 at 02:24:31PM -0700, Junio C Hamano wrote: Unsetting these is not only useless, but can be confusing to a reader, who may wonder why some tests in a script unset them and others do not (t0001 is particularly guilty of this inconsistency, probably because many of its

Re: [PATCH 03/12] t: drop useless sane_unset GIT_* calls

2014-03-24 Thread Junio C Hamano
Jeff King p...@peff.net writes: I do not have a problem with that, as it implicitly covers all of the tests following it. I do not think it is particularly necessary, though. Assuming we start with a known test environment and avoiding polluting it for further tests are basic principles of

Re: [PATCH 03/12] t: drop useless sane_unset GIT_* calls

2014-03-24 Thread Junio C Hamano
Jeff King p...@peff.net writes: Hmph. I am looking at git show HEAD^:t/t0001-init.sh after applying this patch, and it does look consistently done with GIT_CONFIG and GIT_DIR (I am not sure about GIT_WORK_TREE but from a cursory read it is done consistently for tests on non-bare

Re: [PATCH 03/12] t: drop useless sane_unset GIT_* calls

2014-03-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: Several test scripts manually unset GIT_CONFIG and other GIT_* variables. These are generally taken care of for us by test-lib.sh already. Unsetting these is not only useless, but can be confusing to a reader, who may wonder why some tests in a script unset

[PATCH 03/12] t: drop useless sane_unset GIT_* calls

2014-03-20 Thread Jeff King
Several test scripts manually unset GIT_CONFIG and other GIT_* variables. These are generally taken care of for us by test-lib.sh already. Unsetting these is not only useless, but can be confusing to a reader, who may wonder why some tests in a script unset them and others do not (t0001 is