[PATCH 03/13] contrib/subtree: Better Error Handling for add

2013-02-04 Thread David A. Greene
From: "David A. Greene" Check refspecs for validity before passing them on to other commands. This lets us generate more helpful error messages. Signed-off-by: David A. Greene --- contrib/subtree/git-subtree.sh | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/

[PATCH 03/13] contrib/subtree: Better Error Handling for add

2013-02-05 Thread David A. Greene
From: "David A. Greene" Check refspecs for validity before passing them on to other commands. This lets us generate more helpful error messages. Signed-off-by: David A. Greene --- contrib/subtree/git-subtree.sh | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/

Re: [PATCH 03/13] contrib/subtree: Better Error Handling for add

2013-08-02 Thread Andreas Schwab
"David A. Greene" writes: > elif [ $# -eq 2 ]; then > - "cmd_add_repository" "$@" > + git rev-parse -q --verify "$2^{commit}" >/dev/null || > + die "'$2' does not refer to a commit" That doesn't make any sense. $2 is a commit in a remote repository which hasn't