On Mon, Sep 26, 2016 at 09:55:20AM -0700, Junio C Hamano wrote:
> > Instead, we can use parse_object(). Note that this is the
> > same fix done by 94d75d1 (get_short_sha1(): correctly
> > disambiguate type-limited abbreviation, 2013-07-01), but
> > that commit fixed only the committish
Jeff King writes:
> The treeish disambiguation function tries to peel tags, but
> it does so by calling:
>
> deref_tag(lookup_object(sha1), ...);
>
> This will only work if we have previously looked at the tag
> and created a "struct tag" for it. Since parsing revision
>
On Mon, Sep 26, 2016 at 07:59:48AM -0400, Jeff King wrote:
> Subject: Re: [PATCH 04/10] get_short_sha1: peel tags when looking for treeish
>
> The treeish disambiguation function tries to peel tags, but
> it does so by calling:
Probably the subject should be "parse tags when...
The treeish disambiguation function tries to peel tags, but
it does so by calling:
deref_tag(lookup_object(sha1), ...);
This will only work if we have previously looked at the tag
and created a "struct tag" for it. Since parsing revision
arguments typically happens before anything else, this
4 matches
Mail list logo