Re: [PATCH 04/11] files-backend: replace *git_path*() with files_path()

2017-02-14 Thread Duy Nguyen
On Tue, Feb 14, 2017 at 3:58 AM, Ramsay Jones wrote: >> -void files_path(struct files_ref_store *refs, struct strbuf *sb, >> - const char *fmt, ...) __attribute__((format (printf, 3, 4))); > > You only added this in the last commit, so maybe mark it static

Re: [PATCH 04/11] files-backend: replace *git_path*() with files_path()

2017-02-13 Thread Ramsay Jones
On 13/02/17 15:20, Nguyễn Thái Ngọc Duy wrote: > This centralizes all path rewriting of files-backend.c in one place so > we have easier time removing the path rewriting later. There could be > some hidden indirect git_path() though, I didn't audit the code to the > bottom. > > Side note:

[PATCH 04/11] files-backend: replace *git_path*() with files_path()

2017-02-13 Thread Nguyễn Thái Ngọc Duy
This centralizes all path rewriting of files-backend.c in one place so we have easier time removing the path rewriting later. There could be some hidden indirect git_path() though, I didn't audit the code to the bottom. Side note: set_worktree_head_symref() is a bad boy and should not be in