Re: [PATCH 04/12] sequencer.c: use commit-slab to mark seen commits

2018-05-12 Thread Duy Nguyen
On Sat, May 12, 2018 at 3:43 PM, Junio C Hamano wrote: > Jeff King writes: > >> On Sat, May 12, 2018 at 10:00:20AM +0200, Nguyễn Thái Ngọc Duy wrote: >> >>> +define_commit_slab(commit_seen, int); >> >> Yay, this one is nice and simple. :) This is what I had

Re: [PATCH 04/12] sequencer.c: use commit-slab to mark seen commits

2018-05-12 Thread Junio C Hamano
Jeff King writes: > On Sat, May 12, 2018 at 10:00:20AM +0200, Nguyễn Thái Ngọc Duy wrote: > >> +define_commit_slab(commit_seen, int); > > Yay, this one is nice and simple. :) This is what I had hoped for all > along with the slab concept. > > -Peff Does it need to use a full int,

Re: [PATCH 04/12] sequencer.c: use commit-slab to mark seen commits

2018-05-12 Thread Jeff King
On Sat, May 12, 2018 at 10:00:20AM +0200, Nguyễn Thái Ngọc Duy wrote: > +define_commit_slab(commit_seen, int); Yay, this one is nice and simple. :) This is what I had hoped for all along with the slab concept. -Peff

[PATCH 04/12] sequencer.c: use commit-slab to mark seen commits

2018-05-12 Thread Nguyễn Thái Ngọc Duy
It's done so that commit->util can be removed. See more explanation in the commit that removes commit->util. Signed-off-by: Nguyễn Thái Ngọc Duy --- sequencer.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/sequencer.c b/sequencer.c index