It was called "unused", so at least it was self-consistent.
Signed-off-by: Michael Haggerty
---
builtin/reflog.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/reflog.c b/builtin/reflog.c
index 2d85d26..3e11bee 100644
--- a/builtin/reflog.c
+++ b/builtin/refl
Michael Haggerty wrote:
> It was called "unused", so at least it was self-consistent.
The missing context is that this was a callback function that had to
match the each_ref_fn signature (where that parameter is 'flags')
until v1.5.4~14 (reflog-expire: avoid creating new files in a
directory insi
Michael Haggerty wrote:
> --- a/builtin/reflog.c
> +++ b/builtin/reflog.c
> @@ -349,7 +349,7 @@ static int push_tip_to_list(const char *refname, const
> unsigned char *sha1, int
> return 0;
> }
>
> -static int expire_reflog(const char *ref, const unsigned char *sha1, int
> unused, void
On 12/05/2014 12:28 AM, Jonathan Nieder wrote:> Michael Haggerty wrote:
>> It was called "unused", so at least it was self-consistent.
>
> The missing context is that this was a callback function that had to
> match the each_ref_fn signature [...]
>
> With or without a note in the commit message ex
4 matches
Mail list logo
