Re: [PATCH 05/10] submodule: store OIDs in changed_submodule_names

2018-10-26 Thread Jonathan Tan
> Reviewed-by: Jonathan Tan Probably better not to include such lines, especially since the review by me is not yet complete. Having said that, patches 1-5 look good to me. Patches 1-3 are identical to the previous version, which I have already reviewed. In patch 4, Stefan made the code change

[PATCH 05/10] submodule: store OIDs in changed_submodule_names

2018-10-25 Thread Stefan Beller
'calculate_changed_submodule_paths' uses a local list to compute the changed submodules, and then produces the result by copying appropriate items into the result list. Instead use the result list directly and prune items afterwards using string_list_remove_empty_items. By doing so we'll have