Re: [PATCH 05/14] packed-graph: implement construct_graph()

Andreas Schwab writes: > On Jan 26 2018, Junio C Hamano wrote: > >> Also, would >>32 be a problem if commit.date is an uint32 (and >> shifting all its bits out to the right)? > > It would be undefined. Yup, exactly. Thanks.

Re: [PATCH 05/14] packed-graph: implement construct_graph()

On Jan 26 2018, Junio C Hamano wrote: > Also, would >>32 be a problem if commit.date is an uint32 (and > shifting all its bits out to the right)? It would be undefined. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3

Re: [PATCH 05/14] packed-graph: implement construct_graph()

Derrick Stolee writes: > + packedDate[0] = htonl((*list)->date >> 32); > + packedDate[1] = htonl((*list)->date); How forward-looking do we want to be? The commit.date field happens to be unsigned so there is no point masking the result of right

Re: [PATCH 05/14] packed-graph: implement construct_graph()

Stefan Beller writes: > On Thu, Jan 25, 2018 at 6:02 AM, Derrick Stolee wrote: > >> +struct object_id *construct_graph(const char *pack_dir) >> +{ >> + // Find a list of oids, adding the pointer to a list. > > Comment style. > Here is where the bike

Re: [PATCH 05/14] packed-graph: implement construct_graph()

On Thu, Jan 25, 2018 at 6:02 AM, Derrick Stolee wrote: > +struct object_id *construct_graph(const char *pack_dir) > +{ > + // Find a list of oids, adding the pointer to a list. Comment style. Here is where the bike shedding begins. ;)

[PATCH 05/14] packed-graph: implement construct_graph()

Teach Git to write a packed graph file by checking all packed objects to see if they are commits, then store the file in the given pack directory. Signed-off-by: Derrick Stolee --- Makefile | 1 + packed-graph.c | 375