Re: [PATCH 05/17] remove hold_lock_file_for_append

2015-08-11 Thread Jeff King
On Mon, Aug 10, 2015 at 03:36:14PM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: No users of hold_lock_file_for_append remain, so remove it. This does not seem to have anything to do with rotating static buffers used in get_pathname(); the only effect it has is to conflict

Re: [PATCH 05/17] remove hold_lock_file_for_append

2015-08-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: No users of hold_lock_file_for_append remain, so remove it. This does not seem to have anything to do with rotating static buffers used in get_pathname(); the only effect it has is to conflict heavily with Michael's tempfile topic X-. Perhaps this should be part

[PATCH 05/17] remove hold_lock_file_for_append

2015-08-10 Thread Jeff King
From: Jim Hill gjth...@gmail.com No users of hold_lock_file_for_append remain, so remove it. hold_lock_file_for_append copies its target file internally. This makes it too heavyweight for true append-only logging and too limited for anything else (which probably wants to process the contents).