On Fri, Oct 26, 2018 at 12:15 PM Jonathan Tan wrote:
[snip]
> The expected pattern.
>
> This patch looks good to me.
I'll take this as a "Reviewed-by"?
Thanks,
Stefan
> diff --git a/builtin/grep.c b/builtin/grep.c
> index 7da8fef31a..ba7634258a 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -418,7 +418,10 @@ static int grep_submodule(struct grep_opt *opt, struct
> repository *superproject,
> const struct object_id *oid,
>
When constructing a struct repository for a submodule for some revision
of the superproject where the submodule is not contained in the index,
it may not be present in the working tree currently either. In that
situation giving a 'path' argument is not useful. Upgrade the
repo_submodule_init
3 matches
Mail list logo