Re: [PATCH 06/12] builtin/update_ref: convert to struct object_id

2017-07-04 Thread brian m. carlson
On Mon, Jul 03, 2017 at 10:49:39PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Mon, Jul 03 2017, brian m. carlson jotted: > > [...] > > 1 file changed, 34 insertions(+), 35 deletions(-) > > [...] > > struct strbuf err = STRBUF_INIT; > > char *refname; > > - unsigned char new_sha1[20]; > >

Re: [PATCH 06/12] builtin/update_ref: convert to struct object_id

2017-07-03 Thread Ævar Arnfjörð Bjarmason
On Mon, Jul 03 2017, brian m. carlson jotted: > Convert the uses of unsigned char * to struct object_id. I read all of this over (but didn't apply/test it) and it looks good to me, Just a small nit: > [...] > 1 file changed, 34 insertions(+), 35 deletions(-) > [...] > struct strbuf err =

[PATCH 06/12] builtin/update_ref: convert to struct object_id

2017-07-03 Thread brian m. carlson
Convert the uses of unsigned char * to struct object_id. Signed-off-by: brian m. carlson --- builtin/update-ref.c | 69 ++-- 1 file changed, 34 insertions(+), 35 deletions(-) diff --git a/builtin/update-ref.c b/builtin/update-ref.c index 40ccfc193