Re: [PATCH 06/15] ref-filter: move need_color_reset_at_eol into ref_format

2017-07-13 Thread Junio C Hamano
Jeff King writes: > Calling verify_ref_format() doesn't just confirm that the > format is sane; it actually sets some global variables that > will be used later when formatting the refs. These logically > should belong to the ref_format, which would make it > possible to use

[PATCH 06/15] ref-filter: move need_color_reset_at_eol into ref_format

2017-07-13 Thread Jeff King
Calling verify_ref_format() doesn't just confirm that the format is sane; it actually sets some global variables that will be used later when formatting the refs. These logically should belong to the ref_format, which would make it possible to use multiple formats within a single program