Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-13 Thread Jeff King
On Mon, Sep 11, 2017 at 11:40:05PM +0200, René Scharfe wrote: > > Yes, but I didn't want to touch each code site that creates a file, > > which is a lot more invasive. I expect expanding to 4096 (or PATH_MAX) > > would be sufficient in practice. > > Perhaps it is in most cases. Having certainty

Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-11 Thread René Scharfe
Am 10.09.2017 um 19:38 schrieb Jeff King: > On Sun, Sep 10, 2017 at 12:37:06PM +0200, René Scharfe wrote: > >>> And in fact, being called from a signal handler means we should >>> generally avoid touching malloc or free (which could be holding locks). >>> That would mean preferring a leak to

Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-10 Thread Jeff King
On Sun, Sep 10, 2017 at 12:37:06PM +0200, René Scharfe wrote: > > And in fact, being called from a signal handler means we should > > generally avoid touching malloc or free (which could be holding locks). > > That would mean preferring a leak to strbuf_release(). Of course that is > > the tip of

Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-10 Thread René Scharfe
Am 10.09.2017 um 09:30 schrieb Jeff King: > On Sun, Sep 10, 2017 at 08:27:40AM +0200, René Scharfe wrote: > if (junk_work_tree) { strbuf_addstr(, junk_work_tree); remove_dir_recursively(, 0); - strbuf_reset();

Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-10 Thread Jeff King
On Sun, Sep 10, 2017 at 08:27:40AM +0200, René Scharfe wrote: > >>if (junk_work_tree) { > >>strbuf_addstr(, junk_work_tree); > >>remove_dir_recursively(, 0); > >> - strbuf_reset(); > >>} > >> + strbuf_release(); > >> } > > > > The code definitely needs

Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-10 Thread René Scharfe
Am 06.09.2017 um 21:51 schrieb Junio C Hamano: > Rene Scharfe writes: > >> Signed-off-by: Rene Scharfe >> --- >> builtin/clone.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/builtin/clone.c b/builtin/clone.c >> index

Re: [PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-09-06 Thread Junio C Hamano
Rene Scharfe writes: > Signed-off-by: Rene Scharfe > --- > builtin/clone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/clone.c b/builtin/clone.c > index 8d11b570a1..dbddd98f80 100644 > --- a/builtin/clone.c > +++

[PATCH 06/34] clone: release strbuf after use in remove_junk()

2017-08-30 Thread Rene Scharfe
Signed-off-by: Rene Scharfe --- builtin/clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/clone.c b/builtin/clone.c index 8d11b570a1..dbddd98f80 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -487,28 +487,28 @@ N_("Clone succeeded, but