Re: [PATCH 07/10] t1404: demonstrate two problems with reference transactions

2017-09-08 Thread Michael Haggerty
On 09/08/2017 06:44 AM, Junio C Hamano wrote: > Michael Haggerty writes: > >> +git for-each-ref $prefix >actual && >> +grep "Unable to create $Q.*packed-refs.lock$Q: File exists" err && > > I added a squash for doing s/grep/test_i18n&/ here Thanks for the fix. I always forget that gotch

Re: [PATCH 07/10] t1404: demonstrate two problems with reference transactions

2017-09-08 Thread Jeff King
On Fri, Sep 08, 2017 at 01:44:30PM +0900, Junio C Hamano wrote: > Michael Haggerty writes: > > > + git for-each-ref $prefix >actual && > > + grep "Unable to create $Q.*packed-refs.lock$Q: File exists" err && > > I added a squash for doing s/grep/test_i18n&/ here; are there other > issues in

Re: [PATCH 07/10] t1404: demonstrate two problems with reference transactions

2017-09-07 Thread Junio C Hamano
Michael Haggerty writes: > + git for-each-ref $prefix >actual && > + grep "Unable to create $Q.*packed-refs.lock$Q: File exists" err && I added a squash for doing s/grep/test_i18n&/ here; are there other issues in the series, or is the series more or less ready to be polished in 'next'?

Re: [PATCH 07/10] t1404: demonstrate two problems with reference transactions

2017-08-30 Thread Michael Haggerty
On 08/30/2017 07:21 PM, Stefan Beller wrote: > On Tue, Aug 29, 2017 at 1:20 AM, Michael Haggerty > wrote: >> [...] >> +test_expect_failure 'no bogus intermediate values during delete' ' >> + prefix=refs/slow-transaction && >> + # Set up a reference with differing loose and packed vers

Re: [PATCH 07/10] t1404: demonstrate two problems with reference transactions

2017-08-30 Thread Stefan Beller
On Tue, Aug 29, 2017 at 1:20 AM, Michael Haggerty wrote: > Currently, a loose reference is deleted even before locking the > `packed-refs` file, let alone deleting any packed version of the > reference. This leads to two problems, demonstrated by two new tests: > > * While a reference is being del

[PATCH 07/10] t1404: demonstrate two problems with reference transactions

2017-08-29 Thread Michael Haggerty
Currently, a loose reference is deleted even before locking the `packed-refs` file, let alone deleting any packed version of the reference. This leads to two problems, demonstrated by two new tests: * While a reference is being deleted, other processes might see the old, packed value of the refe