Re: [PATCH 07/14] range-diff: respect diff_option.file rather than assuming 'stdout'

2018-07-25 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Jul 23, 2018 at 6:59 PM Stefan Beller wrote: >> On Sun, Jul 22, 2018 at 2:58 AM Eric Sunshine >> wrote: >> > The actual diffs output by range-diff respect diff_option.file, which >> > range-diff passes down the call-chain, thus are destination-agnostic. >> >

Re: [PATCH 07/14] range-diff: respect diff_option.file rather than assuming 'stdout'

2018-07-23 Thread Eric Sunshine
On Mon, Jul 23, 2018 at 6:59 PM Stefan Beller wrote: > On Sun, Jul 22, 2018 at 2:58 AM Eric Sunshine wrote: > > The actual diffs output by range-diff respect diff_option.file, which > > range-diff passes down the call-chain, thus are destination-agnostic. > > However, output_pair_header() is

Re: [PATCH 07/14] range-diff: respect diff_option.file rather than assuming 'stdout'

2018-07-23 Thread Stefan Beller
On Sun, Jul 22, 2018 at 2:58 AM Eric Sunshine wrote: > > The actual diffs output by range-diff respect diff_option.file, which > range-diff passes down the call-chain, thus are destination-agnostic. > However, output_pair_header() is hard-coded to emit to 'stdout'. Fix > this by making

[PATCH 07/14] range-diff: respect diff_option.file rather than assuming 'stdout'

2018-07-22 Thread Eric Sunshine
The actual diffs output by range-diff respect diff_option.file, which range-diff passes down the call-chain, thus are destination-agnostic. However, output_pair_header() is hard-coded to emit to 'stdout'. Fix this by making output_pair_header() respect diff_option.file, as well. Signed-off-by: