Re: [PATCH 07/15] remote.c: report error on failure to fopen()

2017-04-27 Thread Johannes Sixt
Am 27.04.2017 um 11:14 schrieb Duy Nguyen: On Thu, Apr 27, 2017 at 12:07 PM, Johannes Sixt wrote: Am 27.04.2017 um 02:57 schrieb Junio C Hamano: Johannes Sixt writes: +++ git ls-remote 'refs*master' +warning: unable to access '.git/branches/refs*master': Invalid argument fatal: 'refs*mast

Re: [PATCH 07/15] remote.c: report error on failure to fopen()

2017-04-27 Thread Duy Nguyen
On Thu, Apr 27, 2017 at 12:07 PM, Johannes Sixt wrote: > Am 27.04.2017 um 02:57 schrieb Junio C Hamano: >> >> Johannes Sixt writes: >> >>> +++ git ls-remote 'refs*master' >>> +warning: unable to access '.git/branches/refs*master': Invalid argument >>> fatal: 'refs*master' does not appear to be a

Re: [PATCH 07/15] remote.c: report error on failure to fopen()

2017-04-26 Thread Johannes Sixt
Am 27.04.2017 um 02:57 schrieb Junio C Hamano: Johannes Sixt writes: +++ git ls-remote 'refs*master' +warning: unable to access '.git/branches/refs*master': Invalid argument fatal: 'refs*master' does not appear to be a git repository fatal: Could not read from remote repository. Please mak

Re: [PATCH 07/15] remote.c: report error on failure to fopen()

2017-04-26 Thread Junio C Hamano
Johannes Sixt writes: > +++ git ls-remote 'refs*master' > +warning: unable to access '.git/branches/refs*master': Invalid argument > fatal: 'refs*master' does not appear to be a git repository > fatal: Could not read from remote repository. > > Please make sure you have the correct access righ

Re: [PATCH 07/15] remote.c: report error on failure to fopen()

2017-04-26 Thread Johannes Sixt
Am 20.04.2017 um 13:26 schrieb Nguyễn Thái Ngọc Duy: @@ -279,8 +283,12 @@ static void read_branches_file(struct remote *remote) struct strbuf buf = STRBUF_INIT; FILE *f = fopen(git_path("branches/%s", remote->name), "r"); - if (!f) + if (!f) { + if (errn

[PATCH 07/15] remote.c: report error on failure to fopen()

2017-04-20 Thread Nguyễn Thái Ngọc Duy
There's plenty of error() in this code to safely assume --quiet is not a concern. Signed-off-by: Nguyễn Thái Ngọc Duy --- remote.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/remote.c b/remote.c index 801137c72e..8ccc1e7b99 100644 --- a/remote.c +++ b/remote